Move the default tag system into the datamodel#673
Closed
WilliamJamieson wants to merge 23 commits into
Closed
Conversation
…_tag by _create_* and the converters
…ode dynamic creation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #673 +/- ##
==========================================
- Coverage 97.56% 95.25% -2.31%
==========================================
Files 30 27 -3
Lines 2788 2675 -113
==========================================
- Hits 2720 2548 -172
- Misses 68 127 +59 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5 tasks
Contributor
Author
|
We are not planning on making any changes at this time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If/when we remove dynamically generated node classes, the node classes will no longer be able to determine their own default tags (since it will be generic to all tags). This PR moves the default tag handling from the node class into the data model so that the nodes can be made generic with respect to the actual tag involved.
Note this depends on #660, #663, #664, #669, and #670
Tasks
roman_datamodelstests.docs/page.no-changelog-entry-needed.)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types).romancalregression test (https://github.com/spacetelescope/RegressionTests/actions/workflows/romancal.yml) with this branch installed ("git+https://github.com/<fork>/rad@<branch>").News fragment change types:
changes/<PR#>.feature.rst: new featurechanges/<PR#>.bugfix.rst: fixes an issuechanges/<PR#>.doc.rst: documentation changechanges/<PR#>.removal.rst: deprecation or removal of public APIchanges/<PR#>.misc.rst: infrastructure or miscellaneous change